#6 Pydantic Settings as env manager #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrysoK
reviewed
Sep 27, 2024
CrysoK
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Es importante ignorar los archivos
*.session
*.session-journal
porque tienen información sensible sobre la sesión iniciada y podría commitearse por error.
Creo que también debería ignorarse cache.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se modifico el manejo de variables de entorno por pydantic-settings para tener el tipado de los datos, chequeo de las variables de entorno y evitar modificacion en tiempo de ejecucion a las llamadas de las variables de entorno para mayor seguridad.